netdev - Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jun 2018 14:20:05 -0700
From:   Carlos Munoz <cmunoz@...ium.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "Steven J. Hill" <steven.hill@...ium.com>, netdev@...r.kernel.org,
        Chandrakala Chavva <cchavva@...iumnetworks.com>
Subject: Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX
 Ethernet Nexus



On 06/28/2018 01:41 AM, Andrew Lunn wrote:
> External Email
>
>> +static char *mix_port;
>> +module_param(mix_port, charp, 0444);
>> +MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX interfaces.");
>> +
>> +static char *pki_port;
>> +module_param(pki_port, charp, 0444);
>> +MODULE_PARM_DESC(pki_port, "Specifies which ports connect to the PKI.");
> Module parameters are generally not liked. Can you do without them?

These parameters change the kernel port assignment required by user space applications. We rather keep them as they simplify the process.

>
>> +             /* One time request driver module */
>> +             if (is_mix) {
>> +                     if (atomic_cmpxchg(&request_mgmt_once, 0, 1) == 0)
>> +                             request_module_nowait("octeon_mgmt");
> Why is this needed? So long as the driver has the needed properties,
> udev should load the module.
>
>      Andrew

The thing is the management module is only loaded when a port is assigned to it (determined by the above module parameter "mix_port").

Best regards,
Carlos