netdev - Re: [PATCH net-next] l2tp: define helper for parsing struct sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Jun 2018 16:07:10 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     g.nault@...halink.fr
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next] l2tp: define helper for parsing struct
 sockaddr_pppol2tp*

From: Guillaume Nault <g.nault@...halink.fr>
Date: Tue, 26 Jun 2018 18:41:36 +0200

> 'sockaddr_len' is checked against various values when entering
> pppol2tp_connect(), to verify its validity. It is used again later, to
> find out which sockaddr structure was passed from user space. This
> patch combines these two operations into one new function in order to
> simplify pppol2tp_connect().
> 
> A new structure, l2tp_connect_info, is used to pass sockaddr data back
> to pppol2tp_connect(), to avoid passing too many parameters to
> l2tp_sockaddr_get_info(). Also, the first parameter is void* in order
> to avoid casting between all sockaddr_* structures manually.
> 
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Applied.