netdev - Re: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 03 Jul 2018 23:26:09 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     rishabhb@...eaurora.org
Cc:     netdev@...r.kernel.org, neilb@...e.com, tgraf@...g.ch,
        herbert@...dor.apana.org.au, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] lib: rhashtable: Correct self-assignment in
 rhashtable.c

From: Rishabh Bhatnagar <rishabhb@...eaurora.org>
Date: Mon,  2 Jul 2018 09:35:34 -0700

> In file lib/rhashtable.c line 777, skip variable is assigned to
> itself. The following error was observed:
> 
> lib/rhashtable.c:777:41: warning: explicitly assigning value of
> variable of type 'int' to itself [-Wself-assign] error, forbidden
> warning: rhashtable.c:777
> This error was found when compiling with Clang 6.0. Change it to iter->skip.
> 
> Signed-off-by: Rishabh Bhatnagar <rishabhb@...eaurora.org>
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> Reviewed-by: NeilBrown <neilb@...e.com>

Applied, thanks.