netdev - Re: [PATCH net-next 05/18] tls: Refactor tls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Jul 2018 16:29:33 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Boris Pismenny <borisp@...lanox.com>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
        davejwatson@...com, aviadye@...lanox.com, borisp@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [PATCH net-next 05/18] tls: Refactor tls_offload variable names

Hi Boris,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Boris-Pismenny/TLS-offload-rx-netdev-mlx5/20180705-064704
config: x86_64-randconfig-s0-07051307 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Boris-Pismenny/TLS-offload-rx-netdev-mlx5/20180705-064704 HEAD fbaef8a3b3a3283de49a7171144b7471e5c780d9 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net//tls/tls_device.c: In function 'tls_device_free_ctx':
>> net//tls/tls_device.c:55:22: error: 'TLS_HW' undeclared (first use in this function)
     if (ctx->tx_conf == TLS_HW)
                         ^~~~~~
   net//tls/tls_device.c:55:22: note: each undeclared identifier is reported only once for each function it appears in

vim +/TLS_HW +55 net//tls/tls_device.c

    52	
    53	static void tls_device_free_ctx(struct tls_context *ctx)
    54	{
  > 55		if (ctx->tx_conf == TLS_HW)
    56			kfree(tls_offload_ctx_tx(ctx));
    57	
    58		kfree(ctx);
    59	}
    60	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27042 bytes)