netdev - Re: [PATCH] [net-next] devlink: fix incorrect return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 07 Jul 2018 20:07:17 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     jiri@...lanox.com, arkadis@...lanox.com, moshe@...lanox.com,
        dsahern@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] devlink: fix incorrect return statement

From: Arnd Bergmann <arnd@...db.de>
Date: Fri,  6 Jul 2018 14:58:51 +0200

> A newly added dummy helper function tries to return a failure from a "void"
> function:
> 
> In file included from include/net/dsa.h:24,
>                  from arch/arm/plat-orion/common.c:21:
> include/net/devlink.h: In function 'devlink_param_value_changed':
> include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
>   return -EOPNOTSUPP;
> 
> This fixes it by removing the bogus statement.
> 
> Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.