netdev - Re: [PATCH net-next 01/13] ARM: net: bpf: enumerate the JIT scratch stack layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jul 2018 20:30:04 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 01/13] ARM: net: bpf: enumerate the JIT scratch
 stack layout

Hi Russell,

thanks a lot for your work on the arm32 JIT!

On 07/10/2018 02:36 PM, Russell King wrote:
> Enumerate the contents of the JIT scratch stack layout used for storing
> some of the JITs 64-bit registers, tail call counter and AX register.
> 
> XXX: what about the skb_copy_bits buffer - this appears to overlap with
> the first word of the JITs accessible stack.

Could you elaborate on that case? Unless I'm missing something there should
be no use of the skb_copy_bits buffer anymore (aka former SKB_BUFFER at
STACK_VAR(SCRATCH_SIZE) offset), but aside from that it's not supposed to
overlap either.

Thanks,
Daniel