netdev - Re: [PATCH iproute2-next] net:sched: add action inheritdsfield to skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Jul 2018 13:25:09 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     "Fu, Qiaobin" <qiaobinf@...edu>
Cc:     David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Michel Machado <michel@...irati.com.br>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH iproute2-next] net:sched: add action inheritdsfield to skbedit

On Sun, Jul 8, 2018 at 2:27 PM Qiaobin Fu <qiaobinf@...edu> wrote:
> @@ -111,6 +114,9 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
>                         }
>                         flags |= SKBEDIT_F_PTYPE;
>                         ok++;
> +               } else if (matches(*argv, "inheritdsfield") == 0) {
> +                       pure_flags |= SKBEDIT_F_INHERITDSFIELD;
> +                       ok++;
>                 } else if (matches(*argv, "help") == 0) {
>                         usage();
>                 } else {
[...]
> @@ -214,6 +224,11 @@ static int print_skbedit(struct action_util *au, FILE *f, struct rtattr *arg)
>                 else
>                         print_uint(PRINT_ANY, "ptype", " ptype %u", ptype);
>         }
> +       if (tb[TCA_SKBEDIT_FLAGS] != NULL) {
> +               flags = RTA_DATA(tb[TCA_SKBEDIT_FLAGS]);
> +               if (*flags & SKBEDIT_F_INHERITDSFIELD)
> +                       fprintf(f, " inherit DS field ");
> +       }

Please align the output syntax with the input syntax. Traditionally
iproute2 command output can be just used for input, even though
it is no longer true now.