lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jul 2018 10:33:19 +1000 From: Jonathan Maxwell <jmaxwell37@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, David Laight <David.Laight@...lab.com>, kuznet <kuznet@....inr.ac.ru>, yoshfuji <yoshfuji@...ux-ipv6.org>, Netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Jon Maxwell <jmaxwell@...hat.com> Subject: Re: [net-next,v3] tcp: Improve setsockopt() TCP_USER_TIMEOUT accuracy On Tue, Jul 10, 2018 at 10:48 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > > > On 07/10/2018 05:38 AM, Eric Dumazet wrote: > >> Note that if we always do jiffies_to_msecs(icsk->icsk_user_timeout) in TCP, >> we also could change the convention and store msecs in this field instead of jiffies. >> >> That would eliminate the msecs_to_jiffies() and jiffies_to_msecs() dance. >> >> (That would be done in a patch of its own, of course) > > tcp_keepalive_timer() does use icsk->icsk_user_timeout directly in jiffies unit, > but considering keeapalive timers are rarely used, this point would have to > do the msecs_to_jiffies() conversion. and also if icsk->icsk_user_timeout = 0, then timeout in retransmits_timed_out() is in jiffies and that would need to addressed.
Powered by blists - more mailing lists