netdev - Re: [PATCHv2 net 0/2] multicast: init as INCLUDE when join SSM INCLUDE group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 11:20:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, sbrivio@...hat.com, pabeni@...hat.com,
        daniel@...earbox.net, xiyou.wangcong@...il.com,
        hideaki.yoshifuji@...aclelinux.com, fbl@...hat.com
Subject: Re: [PATCHv2 net 0/2] multicast: init as INCLUDE when join SSM
 INCLUDE group

From: Hangbin Liu <liuhangbin@...il.com>
Date: Tue, 10 Jul 2018 22:41:25 +0800

> Based on RFC3376 5.1 and RFC3810 6.1, we should init as INCLUDE when join SSM
> INCLUDE group. In my first version I only clear the group change record. But
> this is not enough as when a new group join, it will init as EXCLUDE and
> trigger an filter mode change in ip/ip6_mc_add_src(), which will clear all
> source addresses' sf_crcount. This will prevent early joined address sending
> state change records if multi source addresses joined at the same time.
> 
> In this v2 patchset, I fixed it by directly initializing the mode to INCLUDE
> for SSM JOIN_SOURCE_GROUP. I also split the original patch into two separated
> patches for IPv4 and IPv6.
> 
> Test: test by myself and customer.

Series applied, thanks!