netdev - Re: [PATCH v3 net-next 2/3] rds: Enable RDS IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 17:52:41 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ka-Cheong Poon <ka-cheong.poon@...cle.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        santosh.shilimkar@...cle.com, davem@...emloft.net,
        sowmini.varadhan@...cle.com, rds-devel@....oracle.com
Subject: Re: [PATCH v3 net-next 2/3] rds: Enable RDS IPv6 support

Hi Ka-Cheong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Ka-Cheong-Poon/rds-Changing-IP-address-internal-representation-to-struct-in6_addr/20180716-011408
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:332:0,
                    from include/linux/kernel.h:14,
                    from net/rds/tcp_listen.c:33:
   net/rds/tcp_listen.c: In function 'rds_tcp_accept_one':
>> include/linux/dynamic_debug.h:124:1: error: expected expression before 'do'
    do {        \
    ^
   include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~
>> net/rds/rds.h:41:32: note: in expansion of macro 'pr_debug'
    #define rdsdebug(fmt, args...) pr_debug("%s(): " fmt, __func__ , ##args)
                                   ^~~~~~~~
>> net/rds/tcp_listen.c:170:2: note: in expansion of macro 'rdsdebug'
     rdsdebug("accepted tcp %pI6c:%u -> %pI6c:%u\n",
     ^~~~~~~~

vim +/pr_debug +41 net/rds/rds.h

8cbd9606 Andy Grover        2009-04-01  39  
ff57087f shamir rabinovitch 2016-10-27  40  #ifdef RDS_DEBUG
39de8281 Andy Grover        2009-02-24 @41  #define rdsdebug(fmt, args...) pr_debug("%s(): " fmt, __func__ , ##args)
39de8281 Andy Grover        2009-02-24  42  #else
39de8281 Andy Grover        2009-02-24  43  /* sigh, pr_debug() causes unused variable warnings */
b9075fa9 Joe Perches        2011-10-31  44  static inline __printf(1, 2)
b9075fa9 Joe Perches        2011-10-31  45  void rdsdebug(char *fmt, ...)
39de8281 Andy Grover        2009-02-24  46  {
39de8281 Andy Grover        2009-02-24  47  }
39de8281 Andy Grover        2009-02-24  48  #endif
39de8281 Andy Grover        2009-02-24  49  

:::::: The code at line 41 was first introduced by commit
:::::: 39de8281791c4a01abcb0d32879530ffa5863c01 RDS: Main header file

:::::: TO: Andy Grover <andy.grover@...cle.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57634 bytes)