netdev - Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Jul 2018 10:03:24 +0300
From:   Claudiu Beznea <Claudiu.Beznea@...rochip.com>
To:     David Miller <davem@...emloft.net>
CC:     <nicolas.ferre@...rochip.com>, <netdev@...r.kernel.org>,
        <jennifer.dahm@...com>, <nathan.sullivan@...com>
Subject: Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs
 computation



On 18.07.2018 20:54, David Miller wrote:
> From: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Date: Wed, 18 Jul 2018 15:58:09 +0300
> 
>>  
>> +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
>> +{
>> +	struct sk_buff *nskb;
>> +	int padlen = ETH_ZLEN - (*skb)->len;
>> +	int headroom = skb_headroom(*skb);
>> +	int tailroom = skb_tailroom(*skb);
>> +	bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb);
>> +	u32 fcs;
> 
> Please keep local variable ordered from longest to shortest line
> (ie. reverse christmas tree format).

OK! Thank you!

> 
> Thank you.
>