netdev - Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jul 2018 19:28:23 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>,
        Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev <netdev@...r.kernel.org>,
        Jiří Pírko <jiri@...nulli.us>,
        thomas.lendacky@....com, Florian Fainelli <f.fainelli@...il.com>,
        "Elior, Ariel" <ariel.elior@...ium.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Santosh Rastapur <santosh@...lsio.com>, madalin.bucur@....com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        tariqt@...lanox.com, Saeed Mahameed <saeedm@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Ganesh GR <ganeshgr@...lsio.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        linux-net-drivers@...arflare.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        grygorii.strashko@...com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup_offload

On 07/20/2018 04:37 PM, Roopa Prabhu wrote:
> On Wed, Jul 18, 2018 at 5:11 PM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
>> One of the recurring complaints is that we do not have, as a driver
>> writer, a central location from which we would be fed offloading rules
>> into a NIC. This was brought up again during Netconf'18 in Boston.
>>
>> This patch just renames ndo_setup_tc to ndo_setup_offload as a very
>> early initial work to prepare for follow up patch that discuss unified
>> flow representation for the existing offload programming APIs.
>>
>> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
>> Acked-by: Jiri Pirko <jiri@...lanox.com>
>> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> 
> ok with a rename,...but this seems to be going from a very specific to
> a completely generic name.
> maybe ndo_setup_flow_offload or ndo_setup_rule_offload might be better ?.

This might be fine as new ndo depending on the use case this will have (?),
but fwiw the term 'flow' or 'rule' would be misleading for what tc offload
would be doing today (e.g. to name one, there's no notion of 'flow' in BPF
offload). Given today this interface is deeply baked into tc, just a rename
might not suffice but should probably move the whole handling around it such
as assembling the offload info into generic net/core/netdev.c as well if this
is the way to go.

> (or maybe i am missing some context and this is really for setting up
> every possible hardware offload ?)