netdev - Re: [PATCH net] enic: do not call enic_change_mtu in enic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Jul 2018 14:45:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gvaradar@...co.com
Cc:     netdev@...r.kernel.org, benve@...co.com
Subject: Re: [PATCH net] enic: do not call enic_change_mtu in enic_probe

From: Govindarajulu Varadarajan <gvaradar@...co.com>
Date: Mon, 30 Jul 2018 09:56:54 -0700

> In commit ab123fe071c9 ("enic: handle mtu change for vf properly")
> ASSERT_RTNL() is added to _enic_change_mtu() to prevent it from being
> called without rtnl held. enic_probe() calls enic_change_mtu()
> without rtnl held. At this point netdev is not registered yet.
> Remove call to enic_change_mtu and assign the mtu to netdev->mtu.
> 
> Fixes: ab123fe071c9 ("enic: handle mtu change for vf properly")
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@...co.com>

Applied.