netdev - Re: [PATCH] Use Kconfig flag to remove support of deprecated BE2/BE3 adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 06 Aug 2018 13:46:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     poros@...hat.com
Cc:     netdev@...r.kernel.org, ivecera@...hat.com,
        sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use Kconfig flag to remove support of deprecated
 BE2/BE3 adapters

From: Petr Oros <poros@...hat.com>
Date: Mon,  6 Aug 2018 14:12:28 +0200

>   Add flags to remove support of deprecated BE2/BE3 adapters.
>   BE2 disable will reduce .ko size by 2kb and BE3 by 3kb.
>   Disable both will reduce .ko size by 9kb.
> 
>   With dissabled support is also removed coresponding PCI IDs
>   and codepath with [BE2|BE3|BEx]_chip checks.
> 
>   New help style in Kconfig
> 
> Signed-off-by: Petr Oros <poros@...hat.com>

Sorry, I'm not too hot about this.

Imagine being one of the people who has one of these cards.

Pulling out detection and working'ness of devices from a driver
is a big step backwards, and I'm sorry I will don't want to be
part of something that facilitates this.

The S390 folks tried something similar in the past and I reject
those changes too.

Thanks.