netdev - Re: [Patch net] vsock: split dwork to avoid reinitializations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Aug 2018 12:39:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, acking@...are.com, stefanha@...hat.com,
        jhansen@...are.com
Subject: Re: [Patch net] vsock: split dwork to avoid reinitializations

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon,  6 Aug 2018 11:06:02 -0700

> syzbot reported that we reinitialize an active delayed
> work in vsock_stream_connect():
> 
> 	ODEBUG: init active (active state 0) object type: timer_list hint:
> 	delayed_work_timer_fn+0x0/0x90 kernel/workqueue.c:1414
> 	WARNING: CPU: 1 PID: 11518 at lib/debugobjects.c:329
> 	debug_print_object+0x16a/0x210 lib/debugobjects.c:326
> 
> The pattern is apparently wrong, we should only initialize
> the dealyed work once and could repeatly schedule it. So we
> have to move out the initializations to allocation side.
> And to avoid confusion, we can split the shared dwork
> into two, instead of re-using the same one.
> 
> Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
> Reported-by: <syzbot+8a9b1bd330476a4f3db6@...kaller.appspotmail.com>
> Cc: Andy king <acking@...are.com>
> Cc: Stefan Hajnoczi <stefanha@...hat.com>
> Cc: Jorgen Hansen <jhansen@...are.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.