netdev - Re: [PATCH lora-next 03/10] net: lora: sx1301: convert to devm registration of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Aug 2018 11:00:07 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     Ben Whitten <ben.whitten@...il.com>
Cc:     starnight@...cu.edu.tw, hasnain.virk@....com,
        netdev@...r.kernel.org, Ben Whitten <ben.whitten@...rdtech.com>
Subject: Re: [PATCH lora-next 03/10] net: lora: sx1301: convert to devm
 registration of netdev

Am 07.08.2018 um 19:32 schrieb Ben Whitten:
> diff --git a/drivers/net/lora/sx1301.c b/drivers/net/lora/sx1301.c
> index 49958f0..54bfc31 100644
> --- a/drivers/net/lora/sx1301.c
> +++ b/drivers/net/lora/sx1301.c
[...]
> @@ -885,7 +889,7 @@ static int sx1301_probe(struct spi_device *spi)
>  	if (IS_ERR(priv->regmap)) {
>  		ret = PTR_ERR(priv->regmap);
>  		dev_err(&spi->dev, "Regmap allocation failed: %d\n", ret);
> -		return err_regmap;

That hints at a build error in an earlier patch.

Regards,
Andreas

> +		return ret;
>  	}
>  
>  	for (i = 0; i < ARRAY_SIZE(sx1301_reg_fields); i++) {
> @@ -897,38 +901,37 @@ static int sx1301_probe(struct spi_device *spi)
>  		if (IS_ERR(priv->regmap_fields[i])) {
>  			ret = PTR_ERR(priv->regmap_fields[i]);
>  			dev_err(&spi->dev, "Cannot allocate regmap field: %d\n", ret);
> -			goto err_regmap;
> +			return ret;
[snip]


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)