[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2018 14:06:59 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Igor Russkikh <igor.russkikh@...antia.com>
Cc: "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
Yana Esina <yana.esina@...antia.com>,
Nikita Danilov <nikita.danilov@...antia.com>
Subject: Re: [PATCH net-next 2/5] net: aquantia: definitions for WOL patch
> -struct __packed hw_aq_atl_utils_fw_rpc {
> +struct __packed hw_atl_utils_fw_rpc {
> u32 msg_id;
Hi Igor
There is no explanation given as to why you decided to rename this
structure. Please do the rename as a standalone patch, no
functionality change. That makes it easier to review the new
functionality.
Andrew
Powered by blists - more mailing lists