netdev - Re: [PATCH net-next] net: add an empty __netif_set_xps_queue() stab in the !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 01:25:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrei Vagin <avagin@...nvz.org>
Cc:     kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
        netdev@...r.kernel.org, Andrei Vagin <avagin@...il.com>
Subject: Re: [PATCH net-next] net: add an empty __netif_set_xps_queue() stab
 in the !CONFIG_XPS case

Hi Andrei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Andrei-Vagin/net-add-an-empty-__netif_set_xps_queue-stab-in-the-CONFIG_XPS-case/20180813-001123
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/icmpv6.h:13:0,
                    from include/linux/ipv6.h:86,
                    from include/net/ipv6.h:16,
                    from include/linux/sunrpc/clnt.h:28,
                    from include/linux/nfs_fs.h:32,
                    from init/do_mounts.c:32:
>> include/linux/netdevice.h:3423:19: error: redefinition of '__netif_set_xps_queue'
    static inline int __netif_set_xps_queue(struct net_device *dev,
                      ^~~~~~~~~~~~~~~~~~~~~
   include/linux/netdevice.h:3409:19: note: previous definition of '__netif_set_xps_queue' was here
    static inline int __netif_set_xps_queue(struct net_device *dev,
                      ^~~~~~~~~~~~~~~~~~~~~

vim +/__netif_set_xps_queue +3423 include/linux/netdevice.h

c9fbb2d2 Krzysztof Kozlowski 2018-08-10  3422  
c9fbb2d2 Krzysztof Kozlowski 2018-08-10 @3423  static inline int __netif_set_xps_queue(struct net_device *dev,
c9fbb2d2 Krzysztof Kozlowski 2018-08-10  3424  					const unsigned long *mask,
c9fbb2d2 Krzysztof Kozlowski 2018-08-10  3425  					u16 index, bool is_rxqs_map)
c9fbb2d2 Krzysztof Kozlowski 2018-08-10  3426  {
c9fbb2d2 Krzysztof Kozlowski 2018-08-10  3427  	return 0;
c9fbb2d2 Krzysztof Kozlowski 2018-08-10  3428  }
537c00de Alexander Duyck     2013-01-10  3429  #endif
537c00de Alexander Duyck     2013-01-10  3430  

:::::: The code at line 3423 was first introduced by commit
:::::: c9fbb2d25295a566b97d62e6904741e8e1702d83 net: Provide stub for __netif_set_xps_queue if there is no CONFIG_XPS

:::::: TO: Krzysztof Kozlowski <krzk@...nel.org>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (6369 bytes)