netdev - Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Aug 2018 10:18:03 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Stephen Hemminger <sthemmin@...rosoft.com>,
        "K . Y . Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "David S . Miller" <davem@...emloft.net>,
        devel@...uxdriverproject.org, netdev@...r.kernel.org
Subject: Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode
 fallback

On Tue, 14 Aug 2018 19:10:50 +0200
Takashi Iwai <tiwai@...e.de> wrote:

> The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback
> to single queue mode") tried to fix the fallback behavior to a single
> queue mode, but it changed the function to return zero incorrectly,
> while the function should return an object pointer.  Eventually this
> leads to a NULL dereference at the callers that expect non-NULL
> value.
> 
> Fix it by returning the proper net_device object.
> 
> Fixes: 916c5e1413be ("hv/netvsc: fix handling of fallback to single queue mode")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>