netdev - Re: [PATCH net 2/2] net_sched: Fix missing res info when create new tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 18:46:36 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net 2/2] net_sched: Fix missing res info when create new
 tc_index filter

On Mon, Aug 13, 2018 at 3:44 AM Hangbin Liu <liuhangbin@...il.com> wrote:
> This is because we didn't update f->result.res when create new filter. Then in
> tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res
> and unbind filter, which will trigger the WARN_ON() in cbq_destroy_class().
>
> Fix it by updating f->result.res when create new filter.
>
> Fixes: 6e0565697a106 ("net_sched: fix another crash in cls_tcindex")
> Reported-by: Li Shuang <shuali@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>