netdev - Re: [PATCH net-next] net: sched: act_ife: always release ife action on init error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Aug 2018 15:52:01 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] net: sched: act_ife: always release ife action
 on init error

On Tue, Aug 14, 2018 at 10:30 AM Vlad Buslov <vladbu@...lanox.com> wrote:
>
> Action init API was changed to always take reference to action, even when
> overwriting existing action. Substitute conditional action release, which
> was executed only if action is newly created, with unconditional release in
> tcf_ife_init() error handling code to prevent double free or memory leak in
> case of overwrite.
>
> Fixes: 4e8ddd7f1758 ("net: sched: don't release reference on action overwrite")
> Reported-by: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Looks good,

Acked-by: Cong Wang <xiyou.wangcong@...il.com>