lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Aug 2018 10:32:45 +0900 From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> To: David Ahern <dsahern@...il.com>, dsahern@...nel.org, netdev@...r.kernel.org Cc: davem@...emloft.net Subject: Re: [PATCH v2 net-next] veth: Free queues on link delete On 2018/08/15 10:29, David Ahern wrote: > On 8/14/18 7:16 PM, Toshiaki Makita wrote: >> Hmm, on second thought this queues need to be freed after veth_close() >> to make sure no packet will reference them. That means we need to free >> them in .ndo_uninit() or destructor. >> (rtnl_delete_link() calls dellink() before unregister_netdevice_many() >> which calls dev_close_many() through rollback_registered_many()) >> >> Currently veth has destructor veth_dev_free() for vstats, so we can free >> queues in the function. >> To be in line with vstats, allocation also should be moved to >> veth_dev_init(). > > given that, can you take care of the free in the proper location? Sure, will cook a patch. Thanks! -- Toshiaki Makita
Powered by blists - more mailing lists