netdev - [PATCH v3 net 0/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Aug 2018 17:35:47 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     kernel@...gutronix.de, netdev@...r.kernel.org, mdf@...nel.org,
        Brad Mouring <brad.mouring@...com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: [PATCH v3 net 0/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke
initializing macb on the EVB-KSZ9477 eval board.

The board's SoC has a macb MAC connected to the KSZ9477 over RGMII, this
is represented as a fixed-link as follows in the (non-mainline) device tree:

	macb0: ethernet@...28000 {
		phy-mode = "rgmii";
		gpios = <&pioB 28 GPIO_ACTIVE_LOW>;
		reset-gpios = <&pioC 31 GPIO_ACTIVE_LOW>;
		status = "okay";

		fixed-link {
			speed = <1000>;
			full-duplex;
		};
	};

The following patch fixes the regression by partially reverting the offending
commit and can be backported to stable.

Follow-up patches that popped up during review will be sent when net-next opens.
They improve error reporting and add a "mdio" subtree binding to contain macb's
MDIO-managed PHYs, similar to the binding in other drivers.

This is v3. v2 started with
Message-Id: <20180820121238.7779-1-a.fatoum@...gutronix.de>.
without explicit marking as v2.
v1 started with Message-Id: <20180814141240.9085-1-a.fatoum@...gutronix.de>.

Changes introduced in v1 and v2 are noted in-line in their respective patches.

Ahmad Fatoum (1):
  net: macb: Fix regression breaking non-MDIO fixed-link PHYs

 drivers/net/ethernet/cadence/macb_main.c | 27 +++++++++++++++---------
 1 file changed, 17 insertions(+), 10 deletions(-)

-- 
2.18.0