netdev - Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Aug 2018 10:45:03 +0530
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Masahisa Kojima <masahisa.kojima@...aro.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

Hi Dave,
   This patch (1/2) seems to have fallen through the cracks. The other
one (2/2), you already picked.
Thanks

On Mon, Apr 16, 2018 at 1:08 PM <jassisinghbrar@...il.com> wrote:
>
> From: Jassi Brar <jaswinder.singh@...aro.org>
>
> Enable TX-irq as well during ndo_open() as we can not count upon
> RX to arrive early enough to trigger the napi. This patch is critical
> for installation over network.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Jassi Brar <jaswinder.singh@...aro.org>
> ---
>  drivers/net/ethernet/socionext/netsec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index f4c0b02..f6fe70e 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
>         napi_enable(&priv->napi);
>         netif_start_queue(ndev);
>
> -       /* Enable RX intr. */
> -       netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
> +       /* Enable TX+RX intr. */
> +       netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
>
>         return 0;
>  err3:
> --
> 2.7.4
>