netdev - Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 04 Sep 2018 14:27:35 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Jose Abreu <Jose.Abreu@...opsys.com>, netdev@...r.kernel.org
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix
 multi-queue races

On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote:
> Hi Jerome,
> 
> On 03-09-2018 17:22, Jerome Brunet wrote:
> > 
> > Situation is even worse with this.
> > I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt
> > anymore. Looks like a the same kind of network breakdown we had previously
> > 
> 
> I was able to reproduce your problem and the attached fixup patch
> fixed it up for me. Can you please try?

I suppose this applies on top the initial patch, not the previous fixup
(judging from the rejection) Could you details the baseline for each
patch you send, its not easy to follow.

BTW, there something weird (at least for me) with the patch you attach.
git always refuse to apply them and even patch complains:

git apply fixup2.patch
error: patch failed: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1861
error: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: patch does not apply

patch -p1 < fixup2.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
Hunk #6 succeeded at 2252 (offset 1 line).                               
patch unexpectedly ends in middle of line
patch unexpectedly ends in middle of line

Anyway, with this second fixup, I'm back to square one:
I can boot but iperf3 won't hold for long


# iperf3 -c 10.1.2.124 -p 12345 -t 600
Connecting to host 10.1.2.124, port 12345
[  4] local 10.1.4.59 port 38650 connected to 10.1.2.124 port 12345
[ ID] Interval           Transfer     Bandwidth       Retr  Cwnd
[  4]   0.00-1.00   sec  80.8 MBytes   678 Mbits/sec    1    300 KBytes
[  4]   1.00-2.00   sec  81.1 MBytes   680 Mbits/sec    0    329 KBytes
[  4]   2.00-3.00   sec  80.7 MBytes   677 Mbits/sec    0    335 KBytes
[  4]   3.00-4.00   sec  81.7 MBytes   685 Mbits/sec    0    337 KBytes
[  4]   4.00-5.00   sec  81.0 MBytes   680 Mbits/sec    0    341 KBytes
[  4]   5.00-6.00   sec  81.0 MBytes   680 Mbits/sec    0    344 KBytes
[  4]   6.00-7.00   sec  80.7 MBytes   677 Mbits/sec    0    345 KBytes
[  4]   7.00-8.00   sec  81.5 MBytes   684 Mbits/sec    0    346 KBytes
[  4]   8.00-9.00   sec  81.2 MBytes   680 Mbits/sec    0    348 KBytes
[  4]   9.00-10.00  sec  5.59 MBytes  46.9 Mbits/sec    2   1.41 KBytes
[  4]  10.00-11.00  sec  0.00 Bytes  0.00 bits/sec    1   1.41 KBytes
[  4]  11.00-12.00  sec  0.00 Bytes  0.00 bits/sec    0   1.41 KBytes
[  4]  12.00-13.00  sec  0.00 Bytes  0.00 bits/sec    1   1.41 KBytes
[  4]  13.00-14.00  sec  0.00 Bytes  0.00 bits/sec    0   1.41 KBytes


> 
> Thanks and Best Regards,
> Jose Miguel Abreu