netdev - Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Sep 2018 09:41:51 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed
 selection

On 09/10/2018 02:52 PM, Andrew Lunn wrote:
> The phy supported speed is being used to determine if the MAC should
> be configured to 100 or 1G. The masking logic is broken. Instead, look
> 1G supported speeds to enable 1G MAC support.

Since you likely need to respin to address the kbuild test robot report
of patch 10, do you mind changing the subject to:

net: bcmgenet: Fix speed selection for reverse MII

to match the subject prefix used throughout past submissions?

Thank you!

> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index b11d58f1bf45..b756fc79424e 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -226,11 +226,10 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
>  		 * capabilities, use that knowledge to also configure the
>  		 * Reverse MII interface correctly.
>  		 */
> -		if ((dev->phydev->supported & PHY_BASIC_FEATURES) ==
> -				PHY_BASIC_FEATURES)
> -			port_ctrl = PORT_MODE_EXT_RVMII_25;
> -		else
> +		if (dev->phydev->supported & PHY_1000BT_FEATURES)
>  			port_ctrl = PORT_MODE_EXT_RVMII_50;
> +		else
> +			port_ctrl = PORT_MODE_EXT_RVMII_25;
>  		bcmgenet_sys_writel(priv, port_ctrl, SYS_PORT_CTRL);
>  		break;
>  
> 


-- 
Florian