netdev - Re: [net 1/1] tipc: fix unsafe rcu locking when accessing publication list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Oct 2018 22:33:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net 1/1] tipc: fix unsafe rcu locking when accessing
 publication list

From: Jon Maloy <jon.maloy@...csson.com>
Date: Fri, 12 Oct 2018 22:46:55 +0200

> From: Tung Nguyen <tung.q.nguyen@...tech.com.au>
> 
> The binding table's 'cluster_scope' list is rcu protected to handle
> races between threads changing the list and those traversing the list at
> the same moment. We have now found that the function named_distribute()
> uses the regular list_for_each() macro to traverse the said list.
> Likewise, the function tipc_named_withdraw() is removing items from the
> same list using the regular list_del() call. When these two functions
> execute in parallel we see occasional crashes.
> 
> This commit fixes this by adding the missing _rcu() suffixes.
> 
> Signed-off-by: Tung Nguyen <tung.q.nguyen@...tech.com.au>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied and queued up for -stable.