netdev - Re: [PATCH mlx5-next 08/10] net/mlx5: Support extended destination format in flow steering command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Dec 2018 11:13:32 -0800
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Jason Gunthorpe <jgg@...lanox.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        elibr@...lanox.com
Subject: Re: [PATCH mlx5-next 08/10] net/mlx5: Support extended destination
 format in flow steering command

On Mon, Dec 10, 2018 at 8:17 AM Jason Gunthorpe <jgg@...lanox.com> wrote:
>
> On Sun, Dec 09, 2018 at 07:04:40PM -0800, Saeed Mahameed wrote:
> > From: Eli Britstein <elibr@...lanox.com>
> >
> > Update the flow steering command formatting according to the extended
> > destination API.
> > Note that the FW dictates that multi destination FTEs that involve at
> > least one encap must use the extended destination format, while single
> > destination ones must use the legacy format.
> > Using extended destination format requires FW support. Check for its
> > capabilities and return error if not supported.
> >
> > Signed-off-by: Eli Britstein <elibr@...lanox.com>
> > Reviewed-by: Or Gerlitz <ogerlitz@...lanox.com>
> > Reviewed-by: Oz Shlomo <ozsh@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> >  .../net/ethernet/mellanox/mlx5/core/fs_cmd.c  | 80 +++++++++++++++++--
> >  include/linux/mlx5/fs.h                       |  2 +
> >  2 files changed, 75 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c
> > index dda63dedaa49..a18fbea7a931 100644
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c
> > @@ -308,22 +308,68 @@ static int mlx5_cmd_destroy_flow_group(struct mlx5_core_dev *dev,
> >       return mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));
> >  }
> >
> > +static int mlx5_set_extended_dest(struct mlx5_core_dev *dev,
> > +                               struct fs_fte *fte, bool *extended_dest)
> > +{
> > +     int fw_log_max_fdb_encap_uplink =
> > +             MLX5_CAP_ESW(dev, log_max_fdb_encap_uplink);
> > +     int num_fwd_destinations = 0;
> > +     struct mlx5_flow_rule *dst;
> > +     int num_encap = 0;
> > +
> > +     *extended_dest = false;
> > +     if (!(fte->action.action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST))
> > +             return 0;
> > +
> > +     list_for_each_entry(dst, &fte->node.children, node.list) {
> > +             if (dst->dest_attr.type == MLX5_FLOW_DESTINATION_TYPE_COUNTER)
> > +                     continue;
> > +             if (dst->dest_attr.type == MLX5_FLOW_DESTINATION_TYPE_VPORT &&
> > +                 dst->dest_attr.vport.flags & MLX5_FLOW_DEST_VPORT_REFORMAT_ID)
> > +                     num_encap++;
> > +             num_fwd_destinations++;
> > +     }
> > +     if (num_fwd_destinations > 1 && num_encap > 0)
> > +             *extended_dest = true;
> > +
> > +     if (*extended_dest && !fw_log_max_fdb_encap_uplink) {
> > +             pr_warn("FW does not support extended destination");
> > +             return -EOPNOTSUPP;
> > +     }
> > +     if (num_encap > (1 << fw_log_max_fdb_encap_uplink)) {
> > +             pr_warn("FW does not support more than %d encaps",
> > +                     1 << fw_log_max_fdb_encap_uplink);
>
> Drivers should avoid using pr_ if they have an struct device, in this
> case &dev->pdev->dev ..
>

Yes ! we will fix this in V2

> This is probably a comment for the entire core code directory I
> suppose?

yes a future patch, a grep shows some places that can be fixed.

>
> Jason