[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2018 17:10:12 +0200
From: Leon Romanovsky <leon@...nel.org>
To: YueHaibing <yuehaibing@...wei.com>
Cc: Saeed Mahameed <saeedm@...lanox.com>, netdev@...r.kernel.org,
linux-rdma@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: Remove set but not used variable
'upriv'
On Wed, Dec 12, 2018 at 08:33:53AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_load':
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1490:21: warning:
> variable 'upriv' set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_unload':
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1557:21: warning:
> variable 'upriv' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit ef381359e3a8 ("net/mlx5e: Replace egdev with
> indirect block notifications"). Also remove unused variable 'uplink_rpriv'
> after this change.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)
Powered by blists - more mailing lists