netdev - Re: [PATCH v3] USB: hso: Fix OOB memory access in hso_probe/hso_get_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 15:41:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        bigeasy@...utronix.de, benquike@...il.com,
        mathias.payer@...elwelt.net
Subject: Re: [PATCH v3] USB: hso: Fix OOB memory access in
 hso_probe/hso_get_config_data

From: Greg KH <gregkh@...uxfoundation.org>
Date: Wed, 12 Dec 2018 12:42:24 +0100

> From: Hui Peng <benquike@...il.com>
> 
> The function hso_probe reads if_num from the USB device (as an u8) and uses
> it without a length check to index an array, resulting in an OOB memory read
> in hso_probe or hso_get_config_data.
> 
> Add a length check for both locations and updated hso_probe to bail on
> error.
> 
> This issue has been assigned CVE-2018-19985.
> 
> Reported-by: Hui Peng <benquike@...il.com>
> Reported-by: Mathias Payer <mathias.payer@...elwelt.net>
> Signed-off-by: Hui Peng <benquike@...il.com>
> Signed-off-by: Mathias Payer <mathias.payer@...elwelt.net>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Applied and queued up for -stable, thanks Greg.