netdev - Re: [PATCH net] bnxt_en: Fix ethtool self-test loopback.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 11:31:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: Fix ethtool self-test loopback.

From: Michael Chan <michael.chan@...adcom.com>
Date: Wed, 19 Dec 2018 13:46:50 -0500

> The current code has 2 problems.  It assumes that the RX ring for
> the loopback packet is combined with the TX ring.  This is not
> true if the ethtool channels are set to non-combined mode.  The
> second problem is that it won't work on 57500 chips without
> adjusting the logic to get the proper completion ring (cpr) pointer.
> Fix both issues by locating the proper cpr pointer through the RX
> ring.
> 
> Fixes: e44758b78ae8 ("bnxt_en: Use bnxt_cp_ring_info struct pointer as parameter for RX path.")
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Applied, thanks Michael.