netdev - Re: [PATCH net] selftests: net: fix/improve ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 04 Jan 2019 13:39:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     posk@...gle.com
Cc:     netdev@...r.kernel.org, posk.devel@...il.com
Subject: Re: [PATCH net] selftests: net: fix/improve ip_defrag selftest

From: Peter Oskolkov <posk@...gle.com>
Date: Fri,  4 Jan 2019 09:43:08 -0800

> Commit ade446403bfb ("net: ipv4: do not handle duplicate fragments as
> overlapping") changed IPv4 defragmentation so that duplicate fragments,
> as well as _some_ fragments completely covered by previously delivered
> fragments, do not lead to the whole frag queue being discarded. This
> makes the existing ip_defrag selftest flaky.
> 
> This patch
> * makes sure that negative IPv4 defrag tests generate truly overlapping
>   fragments that trigger defrag queue drops;
> * tests that duplicate IPv4 fragments do not trigger defrag queue drops;
> * makes a couple of minor tweaks to the test aimed at increasing its code
>   coverage and reduce flakiness.
> 
> Signed-off-by: Peter Oskolkov <posk@...gle.com>

Applied.  Although:

> @@ -37,3 +43,5 @@ ip netns exec "${NETNS}" ./ip_defrag -6
>  echo "ipv6 defrag with overlaps"
>  ip netns exec "${NETNS}" ./ip_defrag -6o
>  
> +echo "all tests done"
> +

Please avoid empty blank lines at the end of files, GIT warns about this
and I have to fix it up.