netdev - Re: [PATCH 2/2] doc: add phylink documentation to the networking book

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190222112033.odgwdzq3h6k6r5mn@shell.armlinux.org.uk>
Date:   Fri, 22 Feb 2019 11:20:33 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-doc@...r.kernel.org, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH 2/2] doc: add phylink documentation to the networking book

Hi Randy,

Sorry for the delay.

On Wed, Feb 13, 2019 at 08:00:29PM -0800, Randy Dunlap wrote:
> On 2/5/19 7:58 AM, Russell King wrote:
> > +uses in-band mode, where results from the PHYs negotiation are passed
> 
>                                              PHY's
...
> > +   Manipulation of the PHY's supported/advertised happens within phylink
> 
>                           PHYs

Either one way or the other.  "negotiation of the PHY", "supported/
advertised (link modes) of the PHY".  Both are posessive, so the first
is a mistake but I don't agree with removing the posessive apostrophy
in the second case.

> > +For information describing the SFP cage in DT, please see the binding
> > +documentation in the kernel source tree
> > +``Documentation/devicetree/bindings/net/sff,sfp.txt``
> oh, so SFP means "Small Form-factor Pluggable".
> 
> I see that this source file:
> ./drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1902:
> 
> seems to imply that SFP means "single function per port (SFP) mode":
> 
> 	dev_err(&pf->pdev->dev,
> 		"VF %d requested polling mode: this feature is supported only when the device is running in single function per port (SFP) mode\n",
> 		 vf->vf_id);

Software engineers endlessly like to create TLAs, so it could mean
both, but in this case it's the official definition from the SFF/
SNIA documents, e.g.:

                          INF-8074i Specification for

                 SFP (Small Formfactor Pluggable) Transceiver

note, no hyphen!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up