netdev - Re: [PATCH net v2] team: use operstate consistently for linkup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190222.114100.892095940715609787.davem@davemloft.net>
Date:   Fri, 22 Feb 2019 11:41:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gwilkie@...tta.att-mail.com
Cc:     jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] team: use operstate consistently for linkup

From: George Wilkie <gwilkie@...tta.att-mail.com>
Date: Wed, 20 Feb 2019 08:19:11 +0000

> When a port is added to a team, its initial state is derived
> from netif_carrier_ok rather than netif_oper_up.
> If it is carrier up but operationally down at the time of being
> added, the port state.linkup will be set prematurely.
> port state.linkup should be set consistently using
> netif_oper_up rather than netif_carrier_ok.
> 
> Fixes: f1d22a1e0595 ("team: account for oper state")
> Signed-off-by: George Wilkie <gwilkie@...tta.att-mail.com>

Applied and queued up for -stable.