netdev - Re: [PATCH 3/3] net: ethernet: add support for high speed mac and usxgmii pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222214404.GP5894@lunn.ch>
Date:   Fri, 22 Feb 2019 22:44:04 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Parshuram Thombare <pthombar@...ence.com>
Cc:     nicolas.ferre@...rochip.com, davem@...emloft.net,
        netdev@...r.kernel.org, f.fainelli@...il.com, hkallweit1@...il.com,
        linux-kernel@...r.kernel.org, rafalc@...ence.com,
        piotrs@...ence.com, jank@...ence.com
Subject: Re: [PATCH 3/3] net: ethernet: add support for high speed mac and
 usxgmii pcs

>  	if (macb_is_gem(bp)) {
> -		linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
> -		if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
> -			linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
> -					 phydev->supported);
> +		if (bp->caps & MACB_CAPS_HIGH_SPEED) {
> +			linkmode_copy(phydev->supported, PHY_10GBIT_FEATURES);
> +		} else {
> +			u32 bitmask = ETHTOOL_LINK_MODE_2500baseT_Full_BIT;
> +
> +			linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
> +			if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
> +				linkmode_set_bit(bitmask, phydev->supported);
> +		}

Same issue again. Somebody could be using a 10G MAC with a 2.5G PHY.

     Andrew