netdev - Re: INFO: task hung in rtnetlink_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222134511.13eb7a82@cakuba.netronome.com>
Date:   Fri, 22 Feb 2019 13:45:11 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Joe Perches <joe@...ches.com>
Cc:     syzbot <syzbot+8218a8a0ff60c19b8eae@...kaller.appspotmail.com>,
        ast@...nel.org, christian@...uner.io, daniel@...earbox.net,
        davem@...emloft.net, dsahern@...il.com, hawk@...nel.org,
        idosch@...lanox.com, john.fastabend@...il.com, kafai@...com,
        ktkhai@...tuozzo.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, petrm@...lanox.com,
        roopa@...ulusnetworks.com, songliubraving@...com,
        syzkaller-bugs@...glegroups.com, xdp-newbies@...r.kernel.org,
        yhs@...com
Subject: Re: INFO: task hung in rtnetlink_rcv_msg

On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote:
> On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote:
> > Hi!
> > 
> > Seems like something funny is going on with get_maintainer.pl since XDP
> > entry got added.  We seem to have been CCed on:  
> 
> I suggest removing the MAINTAINERS line with
> 
> 	K:	xdp
> 
> as xdp is a pretty generic file/patch content
> regex match for the K: type
> 
> $ git grep --name-only xdp | wc -l
> 236
> 
> Rather more files than desired.
> 
> The N: match is dubious too.
> 
> It's generally better to have specific lists of
> maintained file patterns rather than using the
> K: and N: pattern matches.
> 
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d7ad97b235ec..aa703e2cb882 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16970,7 +16970,6 @@ F:	include/net/xdp.h
>  F:	kernel/bpf/devmap.c
>  F:	kernel/bpf/cpumap.c
>  F:	include/trace/events/xdp.h
> -K:	xdp
>  N:	xdp
>  
>  XDP SOCKETS (AF_XDP)

Thanks for the explanation, at least now I know why it happens! :)
I'll leave it to Daniel to decide if we really need it removed, 
so far the false positives weren't overwhelming, just surprising.