netdev - Re: [PATCH net] net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 03 Mar 2019 21:04:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     vivien.didelot@...il.com, andrew@...n.ch, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: handle unknown duplex modes
 gracefully in mv88e6xxx_port_set_duplex

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 1 Mar 2019 19:53:57 +0100

> When testing another issue I faced the problem that
> mv88e6xxx_port_setup_mac() failed due to DUPLEX_UNKNOWN being passed
> as argument to mv88e6xxx_port_set_duplex(). We should handle this case
> gracefully and return -EOPNOTSUPP, like e.g. mv88e6xxx_port_set_speed()
> is doing it.
> 
> Fixes: 7f1ae07b51e8 ("net: dsa: mv88e6xxx: add port duplex setter")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable, thanks Heiner.