netdev - Re: [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Apr 2019 08:31:53 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>
Subject: Re: [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into
 work job

Hello Jakub,

> The split into patches is slightly imperfect here.
> 
> Patch 10 "introduces" a mutex, which nothing is using, yet.
> 
> Patch 11 starts some async work, which the mutex is needed for.
> 
> Patches 12 and 13 wrap other FW call sites...
> 
> Isn't it better to squash 12 and 13 into 10, this way 11 is safe 
> to access FW from the work queue?
> 

Thanks, you are right, will do.

Regards,
  Igor