netdev - RE: [EXT] Re: [PATCH net 1/3] net: ethernet: add property "nvmem_macaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 May 2019 03:10:11 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ynezz@...e.cz" <ynezz@...e.cz>,
        "john@...ozen.org" <john@...ozen.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>
Subject: RE: [EXT] Re: [PATCH net 1/3] net: ethernet: add property
 "nvmem_macaddr_swap" to swap macaddr bytes order

From: Andrew Lunn <andrew@...n.ch> Sent: Saturday, May 11, 2019 2:17 AM
> On Fri, May 10, 2019 at 08:24:00AM +0000, Andy Duan wrote:
> > ethernet controller driver call .of_get_mac_address() to get the mac
> > address from devictree tree, if these properties are not present, then
> > try to read from nvmem.
> >
> > For example, read MAC address from nvmem:
> > of_get_mac_address()
> >       of_get_mac_addr_nvmem()
> >               nvmem_get_mac_address()
> >
> > i.MX6x/7D/8MQ/8MM platforms ethernet MAC address read from nvmem
> ocotp
> > eFuses, but it requires to swap the six bytes order.
> >
> > The patch add optional property "nvmem_macaddr_swap" to swap
> 
> Please use nvmem-macaddr-swap. It is very unusal to use _ in property
> names.
> 
>         Andrew

Thanks, "nvmem-macaddr-swap" string is better. 
I will change "_" to "-" in next version.