netdev - Re: [PATCH net-next] net: phy: bcm87xx: improve bcm87xx_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 26 May 2019 21:57:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: bcm87xx: improve
 bcm87xx_config_init and feature detection

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 24 May 2019 22:24:19 +0200

> PHY drivers don't have to and shouldn't fiddle with phylib internals.
> Most of the code in bcm87xx_config_init() can be removed because
> phylib takes care.
> 
> In addition I replaced usage of PHY_10GBIT_FEC_FEATURES with an
> implementation of the get_features callback. PHY_10GBIT_FEC_FEATURES
> is used by this driver only and it's questionable whether there
> will be any other PHY supporting this mode only. Having said that
> in one of the next kernel versions we may decide to remove it.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.