netdev - Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 May 2019 20:17:30 +0200
From:   Marek Vasut <marex@...x.de>
To:     Guenter Roeck <linux@...ck-us.net>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver

On 5/27/19 5:44 PM, Guenter Roeck wrote:
> On 5/17/19 4:51 PM, Marek Vasut wrote:
>> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special
>> BroadRReach 100BaseT1 PHYs used in automotive.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
>> Cc: Andrew Lunn <andrew@...n.ch>
>> Cc: Florian Fainelli <f.fainelli@...il.com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Heiner Kallweit <hkallweit1@...il.com>
>> Cc: Jean Delvare <jdelvare@...e.com>
>> Cc: linux-hwmon@...r.kernel.org

[...]

>> +static u32 tja11xx_hwmon_in_config[] = {
>> +    HWMON_I_LCRIT_ALARM,
>> +    0
>> +};
>> +
>> +static const struct hwmon_channel_info tja11xx_hwmon_in = {
>> +    .type        = hwmon_in,
>> +    .config        = tja11xx_hwmon_in_config,
>> +};
>> +
>> +static u32 tja11xx_hwmon_temp_config[] = {
>> +    HWMON_T_CRIT_ALARM,
>> +    0
>> +};
>> +
>> +static const struct hwmon_channel_info tja11xx_hwmon_temp = {
>> +    .type        = hwmon_temp,
>> +    .config        = tja11xx_hwmon_temp_config,
>> +};
>> +
>> +static const struct hwmon_channel_info *tja11xx_hwmon_info[] = {
>> +    &tja11xx_hwmon_in,
>> +    &tja11xx_hwmon_temp,
>> +    NULL
>> +};
>> +
> You might want to consider using the new HWMON_CHANNEL_INFO() macro
> to simplify above boilerplate code.
Patch posted

[...]

-- 
Best regards,
Marek Vasut