netdev - Re: [PATCH V3 05/10] net: dsa: microchip: Use PORT_CTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 05:20:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Tristram Ha <Tristram.Ha@...rochip.com>,
        Woojung Huh <Woojung.Huh@...rochip.com>
Subject: Re: [PATCH V3 05/10] net: dsa: microchip: Use PORT_CTRL_ADDR()
 instead of indirect function call

On Mon, Jun 24, 2019 at 12:35:03AM +0200, Marek Vasut wrote:
> The indirect function call to dev->dev_ops->get_port_addr() is expensive
> especially if called for every single register access, and only returns
> the value of PORT_CTRL_ADDR() macro. Use PORT_CTRL_ADDR() macro directly
> instead.

Hi Marek

Rather than change just one instance, it would be better to change
them all. And then remove dev_ops->get_port_addr().

     Andrew