[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Aug 2019 13:23:55 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Jeremy Sowden <jeremy@...zel.net>
Cc: Netfilter Devel <netfilter-devel@...r.kernel.org>,
Net Dev <netdev@...r.kernel.org>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
kadlec@...ckhole.kfki.hu
Subject: Re: [PATCH net-next v1 1/8] netfilter: inlined four headers files
into another one.
Hi Jeremy,
Thanks for working on this.
Cc'ing Jozsef.
On Wed, Aug 07, 2019 at 03:16:58PM +0100, Jeremy Sowden wrote:
[...]
> +/* Called from uadd only, protected by the set spinlock.
> + * The kadt functions don't use the comment extensions in any way.
> + */
> +static inline void
> +ip_set_init_comment(struct ip_set *set, struct ip_set_comment *comment,
> + const struct ip_set_ext *ext)
Not related to this patch, but I think the number of inline functions
could be reduced a bit by exporting symbols? Specifically for
functions that are called from the netlink control plane, ie. _uadd()
functions. I think forcing the compiler to inline this is not useful.
This could be done in a follow up patchset.
Thanks.
Powered by blists - more mailing lists