netdev - Re: [PATCH v3 net-next 04/12] net: aquantia: add PTP rings infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Oct 2019 02:18:49 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     kbuild-all@...ts.01.org,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "epomozov@...vell.com" <epomozov@...vell.com>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Simon Edelhaus <sedelhaus@...vell.com>,
        Igor Russkikh <Igor.Russkikh@...antia.com>,
        Sergey Samoilenko <Sergey.Samoilenko@...antia.com>
Subject: Re: [PATCH v3 net-next 04/12] net: aquantia: add PTP rings
 infrastructure

Hi Igor,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20191023-194531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 88652bf8ce4b91c49769a2a49c17dc44b85b4fa2
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:258:34: sparse: sparse: Using plain integer as NULL pointer

vim +258 drivers/net/ethernet/aquantia/atlantic/aq_ptp.c

   253	
   254	int aq_ptp_ring_alloc(struct aq_nic_s *aq_nic)
   255	{
   256		struct aq_ptp_s *aq_ptp = aq_nic->aq_ptp;
   257		unsigned int tx_ring_idx, rx_ring_idx;
 > 258		struct aq_ring_s *hwts = 0;
   259		u32 tx_tc_mode, rx_tc_mode;
   260		struct aq_ring_s *ring;
   261		int err;
   262	
   263		if (!aq_ptp)
   264			return 0;
   265	
   266		/* Index must to be 8 (8 TCs) or 16 (4 TCs).
   267		 * It depends from Traffic Class mode.
   268		 */
   269		aq_nic->aq_hw_ops->hw_tx_tc_mode_get(aq_nic->aq_hw, &tx_tc_mode);
   270		if (tx_tc_mode == 0)
   271			tx_ring_idx = PTP_8TC_RING_IDX;
   272		else
   273			tx_ring_idx = PTP_4TC_RING_IDX;
   274	
   275		ring = aq_ring_tx_alloc(&aq_ptp->ptp_tx, aq_nic,
   276					tx_ring_idx, &aq_nic->aq_nic_cfg);
   277		if (!ring) {
   278			err = -ENOMEM;
   279			goto err_exit;
   280		}
   281	
   282		aq_nic->aq_hw_ops->hw_rx_tc_mode_get(aq_nic->aq_hw, &rx_tc_mode);
   283		if (rx_tc_mode == 0)
   284			rx_ring_idx = PTP_8TC_RING_IDX;
   285		else
   286			rx_ring_idx = PTP_4TC_RING_IDX;
   287	
   288		ring = aq_ring_rx_alloc(&aq_ptp->ptp_rx, aq_nic,
   289					rx_ring_idx, &aq_nic->aq_nic_cfg);
   290		if (!ring) {
   291			err = -ENOMEM;
   292			goto err_exit_ptp_tx;
   293		}
   294	
   295		hwts = aq_ring_hwts_rx_alloc(&aq_ptp->hwts_rx, aq_nic, PTP_HWST_RING_IDX,
   296					     aq_nic->aq_nic_cfg.rxds,
   297					     aq_nic->aq_nic_cfg.aq_hw_caps->rxd_size);
   298		if (!hwts) {
   299			err = -ENOMEM;
   300			goto err_exit_ptp_rx;
   301		}
   302	
   303		err = aq_ptp_skb_ring_init(&aq_ptp->skb_ring, aq_nic->aq_nic_cfg.rxds);
   304		if (err != 0) {
   305			err = -ENOMEM;
   306			goto err_exit_hwts_rx;
   307		}
   308	
   309		return 0;
   310	
   311	err_exit_hwts_rx:
   312		aq_ring_free(&aq_ptp->hwts_rx);
   313	err_exit_ptp_rx:
   314		aq_ring_free(&aq_ptp->ptp_rx);
   315	err_exit_ptp_tx:
   316		aq_ring_free(&aq_ptp->ptp_tx);
   317	err_exit:
   318		return err;
   319	}
   320	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation