netdev - Re: [PATCH net-next 1/2] ipv6: introduce and uses route look hints for list input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 16 Nov 2019 19:04:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net-next 1/2] ipv6: introduce and uses route look hints
 for list input

Hi Paolo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc7 next-20191115]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-introduce-and-use-route-hint/20191116-172108
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 20021578ba226bda1f0ddf50e4d4a12ea1c6c6c1
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/ipv6/ip6_input.c: In function 'ip6_list_rcv_finish':
>> net/ipv6/ip6_input.c:124:18: error: 'struct netns_ipv6' has no member named 'fib6_has_custom_rules'
       if (!net->ipv6.fib6_has_custom_rules) {
                     ^

vim +124 net/ipv6/ip6_input.c

   100	
   101	static void ip6_list_rcv_finish(struct net *net, struct sock *sk,
   102					struct list_head *head)
   103	{
   104		struct ip6_route_input_hint _hint, *hint = NULL;
   105		struct dst_entry *curr_dst = NULL;
   106		struct sk_buff *skb, *next;
   107		struct list_head sublist;
   108	
   109		INIT_LIST_HEAD(&sublist);
   110		list_for_each_entry_safe(skb, next, head, list) {
   111			struct dst_entry *dst;
   112	
   113			skb_list_del_init(skb);
   114			/* if ingress device is enslaved to an L3 master device pass the
   115			 * skb to its handler for processing
   116			 */
   117			skb = l3mdev_ip6_rcv(skb);
   118			if (!skb)
   119				continue;
   120			ip6_rcv_finish_core(net, sk, skb, hint);
   121			dst = skb_dst(skb);
   122			if (curr_dst != dst) {
   123	#ifndef CONFIG_IPV6_SUBTREES
 > 124				if (!net->ipv6.fib6_has_custom_rules) {
   125					_hint.refdst = skb->_skb_refdst;
   126					memcpy(&_hint.daddr, &ipv6_hdr(skb)->daddr,
   127					       sizeof(_hint.daddr));
   128					hint = &_hint;
   129				}
   130	#endif
   131	
   132				/* dispatch old sublist */
   133				if (!list_empty(&sublist))
   134					ip6_sublist_rcv_finish(&sublist);
   135				/* start new sublist */
   136				INIT_LIST_HEAD(&sublist);
   137				curr_dst = dst;
   138			}
   139			list_add_tail(&skb->list, &sublist);
   140		}
   141		/* dispatch final sublist */
   142		ip6_sublist_rcv_finish(&sublist);
   143	}
   144	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28138 bytes)