netdev - Re: [PATCH] net: smc911x: Adjust indentation in smc911x_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 09 Dec 2019 20:32:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] net: smc911x: Adjust indentation in
 smc911x_phy_configure

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon,  9 Dec 2019 14:50:27 -0700

> Clang warns:
> 
> ../drivers/net/ethernet/smsc/smc911x.c:939:3: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>          if (!lp->ctl_rfduplx)
>          ^
> ../drivers/net/ethernet/smsc/smc911x.c:936:2: note: previous statement
> is here
>         if (lp->ctl_rspeed != 100)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space after the tab on this line.
> Remove it so that the indentation is consistent with the Linux kernel
> coding style and clang no longer warns.
> 
> Fixes: 0a0c72c9118c ("[PATCH] RE: [PATCH 1/1] net driver: Add support for SMSC LAN911x line of ethernet chips")
> Link: https://github.com/ClangBuiltLinux/linux/issues/796
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied.