netdev - Re: [RESEND PATCH net-next] net: vlan: suppress "failed to kill vid" warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Feb 2020 14:31:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jwi@...ux.ibm.com
Cc:     netdev@...r.kernel.org
Subject: Re: [RESEND PATCH net-next] net: vlan: suppress "failed to kill
 vid" warnings

From: Julian Wiedmann <jwi@...ux.ibm.com>
Date: Mon, 17 Feb 2020 13:27:58 +0100

> When a real dev unregisters, vlan_device_event() also unregisters all
> of its vlan interfaces. For each VID this ends up in __vlan_vid_del(),
> which attempts to remove the VID from the real dev's VLAN filter.
> 
> But the unregistering real dev might no longer be able to issue the
> required IOs, and return an error. Subsequently we raise a noisy warning
> msg that is not appropriate for this situation: the real dev is being
> torn down anyway, there shouldn't be any worry about cleanly releasing
> all of its HW-internal resources.
> 
> So to avoid scaring innocent users, suppress this warning when the
> failed deletion happens on an unregistering device.
> While at it also convert the raw pr_warn() to a more fitting
> netdev_warn().
> 
> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>

Applied, thank you.