netdev - Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Apr 2020 09:22:16 +0900
From:   Benjamin Poirier <bpoirier@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input
 and output

On 2020-04-29 08:12 -0700, Roopa Prabhu wrote:
> On Mon, Apr 27, 2020 at 4:51 PM Benjamin Poirier
> <bpoirier@...ulusnetworks.com> wrote:
> >
> > Output the same names for vlan flags as the ones accepted in command input.
> >
> > Signed-off-by: Benjamin Poirier <bpoirier@...ulusnetworks.com>
> > ---
> 
> Benjamin, It's a good change,  but this will break existing users ?.

Nikolay voiced the same concern. The current output looks like

ben@f3:~$ bridge vlan
port    vlan ids
br0     None
tap0     1 PVID Egress Untagged

tap1     1 PVID Egress Untagged

docker0  1 PVID Egress Untagged

ben@f3:~$

"PVID Egress Untagged" look like 3 flags to me. Anything we can do to
improve it?