netdev - Re: [PATCH] ath10k: Acquire tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Jun 2020 09:07:24 -0700
From:   Evan Green <evgreen@...omium.org>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Govind Singh <govinds@....qualcomm.com>, sujitka@...omium.org,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, ath10k@...ts.infradead.org,
        Michal Kazior <michal.kazior@...to.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, kuabhs@...omium.org
Subject: Re: [PATCH] ath10k: Acquire tx_lock in tx error paths

On Mon, Jun 8, 2020 at 4:39 AM Kalle Valo <kvalo@...eaurora.org> wrote:
>
> Evan Green <evgreen@...omium.org> writes:
>
> > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock
> > is held. Acquire the lock in a couple of error paths when calling that
> > function to ensure this condition is met.
> >
> > Fixes: 6421969f248fd ("ath10k: refactor tx pending management")
> > Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64
> > descriptor")
>
> Fixes tag should be in one line, I fixed that in the pending branch.

Ah, got it. Thanks Kalle!
-Evan