netdev - Re: [PATCH net V2] net: Do not clear the sock TX queue in sk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Jun 2020 20:49:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     kuba@...nel.org, edumazet@...gle.com, netdev@...r.kernel.org,
        saeedm@...lanox.com, borisp@...lanox.com
Subject: Re: [PATCH net V2] net: Do not clear the sock TX queue in
 sk_set_socket()

From: Tariq Toukan <tariqt@...lanox.com>
Date: Mon, 22 Jun 2020 23:26:04 +0300

> Clearing the sock TX queue in sk_set_socket() might cause unexpected
> out-of-order transmit when called from sock_orphan(), as outstanding
> packets can pick a different TX queue and bypass the ones already queued.
> 
> This is undesired in general. More specifically, it breaks the in-order
> scheduling property guarantee for device-offloaded TLS sockets.
> 
> Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
> explicitly only where needed.
> 
> Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> Reviewed-by: Boris Pismenny <borisp@...lanox.com>

Applied and queued up for -stable, thank you.